06/10/2020 12:16, Ferruh Yigit: > On 10/5/2020 10:42 AM, Thomas Monjalon wrote: > > As decided in the Technical Board in November 2019, > > the kernel module igb_uio is moved to the dpdk-kmods repository > > in the /linux/igb_uio/ directory.
[...] > Patch doesn't apply cleanly, not sure why, CI seems having same problem: > http://mails.dpdk.org/archives/test-report/2020-October/156378.html That's because I used --irreversible-delete to minimize the size of the patch. [...] > > If UEFI secure boot is enabled, the Linux kernel may disallow the use > > of > > UIO on the system. Therefore, devices for use by DPDK should be bound > > to the > > - ``vfio-pci`` kernel module rather than ``igb_uio`` or > > ``uio_pci_generic``. > > + ``vfio-pci`` kernel module rather than any UIO-based module. > > For more details see :ref:`linux_gsg_binding_kernel` below. > > Should we change the order of the kernel drivers, currently first section is > "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio > out > of the repo, should we list the "VfIO" first? Absolutely. In general we need to encourage more VFIO and remove some references to igb_uio. But I don't want to do such "marketing" change in this patch. The goal of this patch is just to move the code. [...] > > +* kernel: The module ``igb_uio`` has been moved to the git repository > > +``dpdk-kmods`` in a new directory ``linux/igb_uio``. > > + > > Doc build giving warning on this: > WARNING: Bullet list ends without a blank line; unexpected unindent. Probably a merge issue. That's fine on my side. > Except from above minor comments looks good to me, > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> Do we agree I can merge without any change?
