On 10/5/2020 10:42 AM, Thomas Monjalon wrote:
As decided in the Technical Board in November 2019,
the kernel module igb_uio is moved to the dpdk-kmods repository
in the /linux/igb_uio/ directory.

Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.html

Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
Acked-by: Stephen Hemminger <step...@networkplumber.org>
---
v4: Cc more maintainers
v3: update more docs and provide a link to the new repo
v2: update few docs (including release notes)
---
  MAINTAINERS                                |   1 -
  doc/guides/bbdevs/fpga_5gnr_fec.rst        |   3 +-
  doc/guides/bbdevs/fpga_lte_fec.rst         |   3 +-
  doc/guides/cryptodevs/ccp.rst              |   3 +-
  doc/guides/cryptodevs/qat.rst              |   3 +-
  doc/guides/howto/lm_bond_virtio_sriov.rst  |   2 +-
  doc/guides/howto/lm_virtio_vhost_user.rst  |   2 +-
  doc/guides/howto/openwrt.rst               |   5 -
  doc/guides/linux_gsg/enable_func.rst       |   3 +-
  doc/guides/linux_gsg/linux_drivers.rst     |  23 +-
  doc/guides/nics/build_and_test.rst         |   2 +-
  doc/guides/nics/ena.rst                    |   4 +-
  doc/guides/rel_notes/deprecation.rst       |   7 -
  doc/guides/rel_notes/release_20_11.rst     |   4 +-
  doc/guides/sample_app_ug/multi_process.rst |   2 -
  drivers/bus/pci/bsd/pci.c                  |   2 +-
  kernel/linux/igb_uio/Kbuild                |   2 -
  kernel/linux/igb_uio/compat.h              | 154 -----
  kernel/linux/igb_uio/igb_uio.c             | 660 ---------------------
  kernel/linux/igb_uio/meson.build           |  20 -
  kernel/linux/meson.build                   |   2 +-
  21 files changed, 21 insertions(+), 886 deletions(-)
  delete mode 100644 kernel/linux/igb_uio/Kbuild
  delete mode 100644 kernel/linux/igb_uio/compat.h
  delete mode 100644 kernel/linux/igb_uio/igb_uio.c
  delete mode 100644 kernel/linux/igb_uio/meson.build


Patch doesn't apply cleanly, not sure why, CI seems having same problem:
http://mails.dpdk.org/archives/test-report/2020-October/156378.html

<...>

index 7789c572bb..080b44955a 100644
--- a/doc/guides/linux_gsg/linux_drivers.rst
+++ b/doc/guides/linux_gsg/linux_drivers.rst
@@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded 
using the command:
``uio_pci_generic`` module doesn't support the creation of virtual functions. -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio
-module which can be found in the kernel/linux subdirectory referred to above. 
It can
-be loaded as shown below:
+As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module
+which can be found in the repository `dpdk-kmods 
<http://git.dpdk.org/dpdk-kmods>`_.
+It can be loaded as shown below:
.. code-block:: console sudo modprobe uio
-    sudo insmod <build_dir>/kernel/linux/igb_uio/igb_uio.ko
-
-.. note::
-
-   Building DPDK Linux kernel modules is disabled by default starting from 
DPDK 20.02.
-   To enable them again, the config option "enable_kmods" needs to be set
-   in the meson build configuration.
-   See :ref:`adjusting_build_options` for details on how to set/clear build 
options.
-   It is planned to move ``igb_uio`` module to a different git repository.
-
-.. note::
-
-    For some devices which lack support for legacy interrupts, e.g. virtual 
function
-    (VF) devices, the ``igb_uio`` module may be needed in place of 
``uio_pci_generic``.
+    sudo insmod igb_uio.ko
.. note:: If UEFI secure boot is enabled, the Linux kernel may disallow the use of
     UIO on the system. Therefore, devices for use by DPDK should be bound to 
the
-   ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``.
+   ``vfio-pci`` kernel module rather than any UIO-based module.
     For more details see :ref:`linux_gsg_binding_kernel` below.

Should we change the order of the kernel drivers, currently first section is "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out of the repo, should we list the "VfIO" first?

<...>

index 4e61431c6c..243bd940a4 100644
--- a/doc/guides/rel_notes/release_20_11.rst
+++ b/doc/guides/rel_notes/release_20_11.rst
@@ -122,9 +122,11 @@ Removed Items
* vhost: Dequeue zero-copy support has been removed. +* kernel: The module ``igb_uio`` has been moved to the git repository
+``dpdk-kmods`` in a new directory ``linux/igb_uio``.
+


Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.


Except from above minor comments looks good to me,
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>

Reply via email to