Hi
> -----Original Message-----
> From: Dekel Peled <dek...@nvidia.com>
> Sent: Friday, October 2, 2020 12:15 AM
> Subject: [PATCH v2 06/11] net/mlx5: remove handling of ICMP fragmented
> packets
>
> Commit [1] forced setting of match on 'frag' bit mask 1 and value 0.
> Previous patch in this series added support of match on fragmented and
> non-fragmented packets on L3 items, so this setting is now redundant.
>
> This patch removes the changes done in [1].
>
> [1] commit 85407db9f60d ("net/mlx5: fix matching for ICMP fragments")
>
> Signed-off-by: Dekel Peled <dek...@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 79fdf34..0a0a5a4 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -7345,12 +7345,6 @@ struct field_modify_info modify_tcp[] = {
> return;
> if (!icmp6_m)
> icmp6_m = &rte_flow_item_icmp6_mask;
> - /*
> - * Force flow only to match the non-fragmented IPv6 ICMPv6 packets.
> - * If only the protocol is specified, no need to match the frag.
> - */
> - MLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1);
> - MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0);
> MLX5_SET(fte_match_set_misc3, misc3_m, icmpv6_type, icmp6_m-
> >type);
> MLX5_SET(fte_match_set_misc3, misc3_v, icmpv6_type,
> icmp6_v->type & icmp6_m->type);
> @@ -7398,12 +7392,6 @@ struct field_modify_info modify_tcp[] = {
> return;
> if (!icmp_m)
> icmp_m = &rte_flow_item_icmp_mask;
> - /*
> - * Force flow only to match the non-fragmented IPv4 ICMP packets.
> - * If only the protocol is specified, no need to match the frag.
> - */
> - MLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1);
> - MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0);
> MLX5_SET(fte_match_set_misc3, misc3_m, icmp_type,
> icmp_m->hdr.icmp_type);
> MLX5_SET(fte_match_set_misc3, misc3_v, icmp_type,
> --
> 1.8.3.1
Acked-by: Ori Kam <or...@nvidia.com>
Thanks,
Ori
