On 9/9/20 5:32 PM, Ferruh Yigit wrote: > On 9/8/2020 10:14 AM, Andrew Rybchenko wrote: >> Network and vDPA drivers share libefx. So, libefx should be moved >> to common drivers. >> >> DPDK adaptation of the MCDI interface may be shared as well. >> >> The new common driver name is sfc_efx since it a new home of >> libefx base driver. sfc_ prefix is used to make it clear that >> it is related to net/sfc (and vdpa/sfc in the future). >> >> In theory, right now all exported libefx functions should be marked >> as internal, but it requires corresponding markup in base driver >> which sources should have no DPDK specifics since shared by many >> drivers. So, it is unclear what to do and how to solve it. >> > Can a osdep.h can be added, like some other drivers do? > In that header a macro can be expanded to '__rte_internal' for DPDK, and empty > for others...
Thanks Ferruh, we have discussed the idea and will go this way. I'll send v2 patches today.
