On 9/8/2020 10:14 AM, Andrew Rybchenko wrote: > Network and vDPA drivers share libefx. So, libefx should be moved > to common drivers. > > DPDK adaptation of the MCDI interface may be shared as well. > > The new common driver name is sfc_efx since it a new home of > libefx base driver. sfc_ prefix is used to make it clear that > it is related to net/sfc (and vdpa/sfc in the future). > > In theory, right now all exported libefx functions should be marked > as internal, but it requires corresponding markup in base driver > which sources should have no DPDK specifics since shared by many > drivers. So, it is unclear what to do and how to solve it. >
Can a osdep.h can be added, like some other drivers do? In that header a macro can be expanded to '__rte_internal' for DPDK, and empty for others... > > The patch series makes these functions a part of DPDK_21 ABI to > pass build checks. checkpatches.sh does not like it. > > Cc: Thomas Monjalon <tho...@monjalon.net> > Cc: David Marchand <david.march...@redhat.com> > Cc: Ferruh Yigit <ferruh.yi...@intel.com> > > Andrew Rybchenko (14): > net/sfc: include header with debug helpers directly > net/sfc: introduce common driver library > net/sfc: add dedicated header file with MCDI interface > net/sfc: move MCDI helper interface to dedicated namespace > net/sfc: make MCDI logging helper macros local > net/sfc: start to make MCDI helpers interface shareable > net/sfc: use own logging helper macros > net/sfc: avoid usage of NIC pointer from adapter context > net/sfc: avoid panic in the case of MCDI timeout > net/sfc: add MCDI callbacks to allocate/free DMA memory > net/sfc: add MCDI callback to schedule restart > net/sfc: add MCDI callback to poll management event queue > net/sfc: use MCDI control structure as libefx ops context > net/sfc: move MCDI helpers to common driver > <...>
