> -----Original Message-----
> From: Eads, Gage <gage.e...@intel.com>
> Sent: Monday, September 14, 2020 3:56 PM
> To: McDaniel, Timothy <timothy.mcdan...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Mcnamara, John <john.mcnam...@intel.com>;
> Kovacevic, Marko <marko.kovace...@intel.com>; Ray Kinsella
> <m...@ashroe.eu>; Neil Horman <nhor...@tuxdriver.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carri...@intel.com>; Van Haaren,
> Harry <harry.van.haa...@intel.com>; jer...@marvell.com
> Subject: RE: [PATCH v4 01/22] event/dlb: add documentation and meson
> infrastructure
>
> > diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb.rst
> > new file mode 100644
> > index 0000000..e5759c0
> > --- /dev/null
> > +++ b/doc/guides/eventdevs/dlb.rst
>
> Please add a dlb entry to doc/guides/eventdevs/index.rst
Done. Will be available in V5.
>
> > @@ -0,0 +1,340 @@
> > +.. SPDX-License-Identifier: BSD-3-Clause
> > + Copyright(c) 2020 Intel Corporation.
> > +
> > +Driver for the Intel® Dynamic Load Balancer (DLB)
> > +==================================================
> > +
> > +The DPDK dlb poll mode driver supports the Intel® Dynamic Load Balancer.
> > +
> > +Prerequisites
> > +-------------
> > +
> > +- Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to
> > setup
> > + the basic DPDK environment.
>
> It would be better to remove the bullet point ('-'), I think, since there's
> only
> One sentence in the section.
>
Done. Will be available in V5.
> > +
> > +Configuration
> > +-------------
> > +
> > +* The DLB PF PMD is a user-space PMD that uses VFIO to gain direct
> > + device access. To use this operation mode, the PCIe PF device must be
> > bound
> > + to a DPDK-compatible VFIO driver, such as vfio-pci.
>
> Same here ('*')
Done. Will be available in V5.
>
> [...]
>
> > +Atomic Inflights Allocation
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +In the last stage prior to scheduling an atomic event to a CQ, DLB holds
> > the
> > +inflight event in a temporary buffer that is divided among load-balanced
> > +queues. If a queue's atomic buffer storage fills up, this can result in
> > +head-of-line-blocking. For example:
>
> You need a space between these two lines for doxygen to render the bullet
> points properly.
Done. Will be available in V5.
>
> Thanks,
> Gage
