On Thu, Sep 10, 2020 at 10:16:57AM +0100, Bruce Richardson wrote:
> On Thu, Sep 10, 2020 at 01:55:25AM +0000, SteveX Yang wrote:
> > meson build cannot find the header rte_eth_bond.h when build DPDK first
> > time or never installed DPDK lib after build via meson/ninja.
> >
> > Because the corresponding header directory isn't included after enabled
> > RTE_LIBRTE_PMD_BOND macro.
> >
> > Add the header file location and link library to meson.build of test-pmd
> >
> > Signed-off-by: SteveX Yang <stevex.y...@intel.com>
> > ---
>
> While there is a problem here, I think the solution may itself be
> incomplete. Since the bonding PMD is always enabled by default, it's
> support should always be enabled in testpmd. Therefore, testpmd should be
> using the RTE_LIBRTE_BOND_PMD macro internally, not RTE_LIBRTE_PMD_BOND
> one. Once that macro is changed, the issue you report becomes generally
> visible.
>
I also think a release note entry about the macro change would be good.
Similarly for the latency stats one, depending on the fix chosen.