Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Wednesday, September 9, 2020 8:06 PM
> To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline
> type
>
> On Tue, 8 Sep 2020 21:17:50 +0100
> Cristian Dumitrescu <cristian.dumitre...@intel.com> wrote:
>
> > +/*
> > + * Pipeline.
> > + */
> > +struct rte_swx_pipeline {
> > + int build_done;
> > + int numa_node;
> > +};
> > +
> > +
>
> Is int the right type for these.
> build_done seems like a Boolean
Isn't the difference between int and bool mostly cosmetic?
AFAIK we don't have a hard rule in DPDK about bool vs. int.
> and numa_node should be unsigned?
All the functions in libnuma use int as the numa_node type, please see: man 3
numa.
Regards,
Cristian
