From: Ajit Khaparde <ajit.khapa...@broadcom.com> Sent: Saturday, August 8, 2020 8:10 PM To: Kiran Kumar Kokkilagadda <kirankum...@marvell.com> Cc: Andrew Rybchenko <arybche...@solarflare.com>; Ferruh Yigit <ferruh.yi...@intel.com>; Thomas Monjalon <tho...@monjalon.net>; beilei.x...@intel.com; ch...@att.com; cloud.wangxiao...@huawei.com; cristian.dumitre...@intel.com; dev@dpdk.org; gr...@u256.net; hemant.agra...@nxp.com; humi...@huawei.com; hyon...@cisco.com; jasvinder.si...@intel.com; Jerin Jacob Kollanukkaran <jer...@marvell.com>; jia....@intel.com; jingjing...@intel.com; johnd...@cisco.com; keith.wi...@intel.com; Liron Himi <lir...@marvell.com>; ma...@mellanox.com; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; or...@mellanox.com; qi.z.zh...@intel.com; qiming.y...@intel.com; rahul.lakkire...@chelsio.com; Rasesh Mody <rm...@marvell.com>; rosen...@intel.com; sachin.sax...@nxp.com; shah...@mellanox.com; Shahed Shaikh <shsha...@marvell.com>; somnath.ko...@broadcom.com; viachesl...@mellanox.com; wei.zh...@intel.com; xavier.hu...@huawei.com; xuanziya...@huawei.com; yisen.zhu...@huawei.com; zhouguoy...@huawei.com Subject: [EXT] Re: [dpdk-dev][PATCH v2 1/2] ethdev: add level support for RSS offload types
External Email ________________________________ On Sat, Aug 8, 2020 at 7:36 AM <kirankum...@marvell.com<mailto:kirankum...@marvell.com>> wrote: From: Kiran Kumar K <kirankum...@marvell.com<mailto:kirankum...@marvell.com>> This patch reserves 2 bits as input selection to select Inner and outer layers for RSS computation. It is combined with existing ETH_RSS_* to choose Inner or outer layers for L2, L3 and L4. How do you plan to use this? Do you need to make any changes to testpmd? I will update in the next version. This functionality already exists in rte_flow through level parameter in RSS action configuration rte_flow_action_rss. Signed-off-by: Kiran Kumar K <kirankum...@marvell.com<mailto:kirankum...@marvell.com>> --- v2 changes: * Reserved bit 50 & 51 lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index d29930fd8..28184cc85 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -552,6 +552,33 @@ struct rte_eth_rss_conf { #define RTE_ETH_RSS_L3_PRE64 (1ULL << 53) #define RTE_ETH_RSS_L3_PRE96 (1ULL << 52) +/* + * We use the following macros to combine with the above layers to choose + * inner and outer layers or both for RSS computation. + * Note: Default is 0: inner layers, 1: outer layers, 2: both + * bit 50 and 51 are reserved for this. + */ + +/** + * Level 0, It basically stands for the innermost encapsulation level RSS + * can be performed on according to PMD and device capabilities. + */ +#define ETH_RSS_LEVEL_INNER (0ULL << 50) +/** + * Level 1, It basically stands for the outermost encapsulation level RSS + * can be performed on according to PMD and device capabilities. + */ +#define ETH_RSS_LEVEL_OUTER (1ULL << 50) +/** + * Level 2, It basically stands for the both inner and outermost + * encapsulation level RSS can be performed on according to PMD and + * device capabilities. + */ +#define ETH_RSS_LEVEL_INNER_OUTER (2ULL << 50) +#define ETH_RSS_LEVEL_MASK (3ULL << 50) + +#define ETH_RSS_LEVEL(rss_hf) ((rss_hf & ETH_RSS_LEVEL_MASK) >> 50) + /** * For input set change of hash filter, if SRC_ONLY and DST_ONLY of * the same level are used simultaneously, it is the same case as -- 2.25.1
