05/08/2020 15:54, Thomas Monjalon: > 05/08/2020 15:34, Adrian Moreno: > > On 8/5/20 11:12 AM, Thomas Monjalon wrote: > > > 04/08/2020 09:38, Adrian Moreno: > > >> --- a/devtools/checkpatches.sh > > >> +++ b/devtools/checkpatches.sh > > >> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > > >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > > >> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ > > >> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > > >> -NEW_TYPEDEFS,COMPARISON_TO_NULL" > > >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" > > > > > > I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO > > > to maintain a bit of logic ordering. > > > > > OK. I'll reorder it if the final decision is to ignore the check. > > Yes thanks
Applied with above change.
