Hello Pawel, See answers inline.
Regards Sunil Kumar Kori >-----Original Message----- >From: David Marchand <david.march...@redhat.com> >Sent: Wednesday, August 5, 2020 1:30 PM >To: Pawel Wodkowski <pawel...@gmail.com> >Cc: dev <dev@dpdk.org>; Jerin Jacob Kollanukkaran <jer...@marvell.com>; >Sunil Kumar Kori <sk...@marvell.com> >Subject: [EXT] Re: [dpdk-dev] [PATCH] tracepoint: fix compilation with C++ > >External Email > >---------------------------------------------------------------------- >Hello Pawel, > >Thanks for contributing to DPDK. > > >On Tue, Aug 4, 2020 at 7:52 PM Pawel Wodkowski <pawel...@gmail.com> >wrote: >> >> trace_mem is declared as 'void *' which triggers following error: >> '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’ >> [-fpermissive]...' >> >> Fix this by changing void to struct __rte_trace_header trace_mem is intentionally kept as void * so that it can not be accessed by application directly as it part of global header. If I understood the problem correctly, it is because of using trace_mem without typecasting and GCC does not report it as error due to implicit typecast and G++ reports it as error as it does not do implicit typecasting. If this is the case then, I think it is better to typecast the trace_mem where ever it is being used. Anyways that will be safe for both GCC and G++. @Jerin Jacob Kollanukkaran Please suggest. If you have some thing mind. [snippet] --
