Hi, Jeff > -----Original Message----- > From: Sun, GuinanX > Sent: Monday, July 27, 2020 12:54 PM > To: Guo, Jia <jia....@intel.com>; dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Ludkiewicz, Adam > <adam.ludkiew...@intel.com> > Subject: RE: [PATCH 5/8] net/i40e/base: check return value of DNL admin > command > > Hi Jeff > > > -----Original Message----- > > From: Guo, Jia > > Sent: Monday, July 27, 2020 12:08 PM > > To: Sun, GuinanX <guinanx....@intel.com>; dev@dpdk.org > > Cc: Xing, Beilei <beilei.x...@intel.com>; Ludkiewicz, Adam > > <adam.ludkiew...@intel.com> > > Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL > > admin command > > > > hi, guinan > > > > On 7/21/2020 3:39 PM, Guinan Sun wrote: > > > Check return value of running DNL admin command. > > > > > > What is "DNL", I am not sure i know the reason it appear here, could > > you double check it? > > > > Regarding what DNL stands for, I haven't found it in the code and datasheet. > It can be seen from the code change that the return value check operation of > i40e_aq_run_phy_activity has been added. > The description of this function is RUN DNL admin command. > So tile and commit log have made such changes.
Sorry, I might have misunderstood it just now. I will double check for it and patch V2 will modify it. > > > > > > > > > Signed-off-by: Adam Ludkiewicz <adam.ludkiew...@intel.com> > > > Signed-off-by: Guinan Sun <guinanx....@intel.com> > > > --- > > > drivers/net/i40e/base/i40e_common.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/base/i40e_common.c > > b/drivers/net/i40e/base/i40e_common.c > > > index 46a0b7881..85c22849e 100644 > > > --- a/drivers/net/i40e/base/i40e_common.c > > > +++ b/drivers/net/i40e/base/i40e_common.c > > > @@ -7097,7 +7097,7 @@ enum i40e_status_code > > i40e_get_lpi_counters(struct i40e_hw *hw, > > > > > I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT, > > > &cmd_status, tx_counter, rx_counter, > > > NULL); > > > > > > - if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC) > > > + if (!retval && cmd_status != > > I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC) > > > retval = I40E_ERR_ADMIN_QUEUE_ERROR; > > > > > > return retval;
