Hi Thomas, > > 15/07/2020 20:26, Akhil Goyal: > > Hi Arek, > > > > > > Due to increasing interest in multi process support for crypto PMDs > > > new test app can be added so in overview we can say that: > > > > > > The Multi-process Crypto application is a simple application that > > > allows to run crypto related operations in a multiple process > > > environment. It > > > builds on the EAL primary/secondary process infrastructure. > > > > > > v3: > > > - split into multiple patches > > > - refactored parts of code > > > > Looking at the comments on this patchset, I believe the app may not > > be ready by RC2 which falls at end of this week for crypto tree. > > I have not started review of the application yet. > > I see it getting deferred for the next release if it is not added in RC3. > > In general applications are approved by the technical board. > This app was not discussed at all. > And I think it will be rejected, > because I don't see the value of adding a test application just for > multi-process usage. > Is this a recent change that a new application need to be discussed in techboard first? I see that test-sad was added without discussion in the techboard.
I see this application as a useful tool to test the readiness of a driver to be used in a multi process environment. If app is not a correct place to host it, should it be added in examples/multi_process/. I also suggested that in v2 but it makes more sense in app as it is a unit test application which does not have any relevance as standalone application as crypto may not be used standalone without ethernet for multi process scenario. My first preference was to modify l2fwd-crypto to be used as a multi process proof Application but it also make sense to have a unit test application to verify standalone crypto PMDs. Open for comments from other crypto PMD owners. Regards, Akhil