12.07.2020 10:35, Thomas Monjalon пишет: > 11/07/2020 20:58, Ivan Dyukov: >> 11.07.2020 14:27, Thomas Monjalon пишет: >>> 11/07/2020 12:43, Ivan Dyukov: >>>> +__rte_experimental >>>> +int rte_eth_link_printf(const char *const fmt, >>>> + const struct rte_eth_link *eth_link); >>>> >>> Maybe I missed your reply, >>> I still don't understand the need for this function. >>> >> I used it few times in apps in this patchset. It allows to avoid code >> duplication in examples. i.e. declare array, call rte_eth_link_to_str, >> call printf. >> >> It's simple and usefull function. Why not? > Why not is not a good justification :) I still don't understand your objections against this tiny shiny function. > We must avoid adding too much in the API. > > I agree that this function is superfluous for DPDK library, but I would note that it's not just 'DPDK library' change, it's 'DPDK library + DPDK examples' change. With this change, the entire code is getting better. The new function adds usefull functionality. It allows to reduce code size and remove duplicates. so technically it's good change but practically I would like to ask maintainers to decide this.
P.S. I'll we on vacation next two weeks. May be I'll check email but I don't guarantee that.
