On Sun, 12 Jul 2020 09:35:23 +0200 Thomas Monjalon <tho...@monjalon.net> wrote:
> 11/07/2020 20:58, Ivan Dyukov: > > 11.07.2020 14:27, Thomas Monjalon пишет: > > > 11/07/2020 12:43, Ivan Dyukov: > > >> +__rte_experimental > > >> +int rte_eth_link_printf(const char *const fmt, > > >> + const struct rte_eth_link *eth_link); > > >> > > > Maybe I missed your reply, > > > I still don't understand the need for this function. > > > > > I used it few times in apps in this patchset. It allows to avoid code > > duplication in examples. i.e. declare array, call rte_eth_link_to_str, > > call printf. > > > > It's simple and usefull function. Why not? > > Why not is not a good justification :) > We must avoid adding too much in the API. > > I agree with Thomas, this whole exercise seems like a lot of effort for a log message that probably should be debug only. The DPDK should adopt the policy that all core and drivers print no log messages by default, and only log at NOTICE or higher in case of error.
