> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Tuesday, July 7, 2020 10:30 PM > To: Phil Yang <phil.y...@arm.com> > Cc: tho...@monjalon.net; Erik Gabriel Carrillo <erik.g.carri...@intel.com>; > dpdk-dev <dev@dpdk.org>; jer...@marvell.com; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; David Christensen > <d...@linux.vnet.ibm.com>; Ruifeng Wang <ruifeng.w...@arm.com>; > Dharmik Thakkar <dharmik.thak...@arm.com>; nd <n...@arm.com>; David > Marchand <david.march...@redhat.com>; Ray Kinsella <m...@ashroe.eu>; > Neil Horman <nhor...@tuxdriver.com>; do...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v3 4/4] eventdev: relax smp barriers with > C11 atomics > > On Tue, Jul 7, 2020 at 4:45 PM Phil Yang <phil.y...@arm.com> wrote: > > > > The impl_opaque field is shared between the timer arm and cancel > > operations. Meanwhile, the state flag acts as a guard variable to > > make sure the update of impl_opaque is synchronized. The original > > code uses rte_smp barriers to achieve that. This patch uses C11 > > atomics with an explicit one-way memory barrier instead of full > > barriers rte_smp_w/rmb() to avoid the unnecessary barrier on aarch64. > > > > Since compilers can generate the same instructions for volatile and > > non-volatile variable in C11 __atomics built-ins, so remain the volatile > > keyword in front of state enum to avoid the ABI break issue. > > > > Signed-off-by: Phil Yang <phil.y...@arm.com> > > Reviewed-by: Dharmik Thakkar <dharmik.thak...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > Acked-by: Erik Gabriel Carrillo <erik.g.carri...@intel.com> > > > Could you fix the following: > > WARNING:TYPO_SPELLING: 'opague' may be misspelled - perhaps 'opaque'? > #184: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:1161: > + * specific opague data under the correct state. Done.
Thanks, Phil
