> -----Original Message----- > From: Andrew Rybchenko <arybche...@solarflare.com> > Sent: Tuesday, July 7, 2020 11:45 AM > To: dev@dpdk.org > Cc: Igor Romanov <igor.roma...@oktetlabs.ru>; sta...@dpdk.org; Van Haaren, > Harry <harry.van.haa...@intel.com> > Subject: [PATCH v3 1/2] service: fix wrong lcore indices > > From: Igor Romanov <igor.roma...@oktetlabs.ru> > > The service core list is populated, but not used. Incorrect > lcore states are examined for a service. > > Use the populated list to iterate over service cores. > > Fixes: e30d d318 47d2 ("service: add mechanism for quiescing") > Cc: sta...@dpdk.org
I believe the original adding of quiescing did not have this exact bug (ids[] was used)? It seems to have been introduced when reworking to avoid false sharing, so fixes is: Fixes: e484ccddbe1b ("services: avoid false sharing on core state") > Signed-off-by: Igor Romanov <igor.roma...@oktetlabs.ru> > Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> Code change itself: Acked-by: Harry van Haaren <harry.van.haa...@intel.com> <snip patch>