Hi Stephen, > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Subject: Re: [dpdk-dev] [PATCH v3 0/7] support the flow-based traffic sampling > > On Mon, 6 Jul 2020 20:51:01 +0300 > Jiawei Wang <jiaw...@mellanox.com> wrote: > > > This patch set implement the flow sampling for mlx5 driver. > > > > The solution is introduced a new rte_flow action that will sample the > incoming traffic and send a duplicated traffic with the specified ratio to the > application, while the original packet will continue to the target > destination. > > > > If the sample ratio value be set to 1, means that the packets would be > completely mirrored. The sample packet can be assigned with different set of > actions from the original packet. > > > > MLX5 PMD driver will be responsible for validate and translate the sample > action while creating a flow. > > > > You seem to have ignored my feedback that this could be more useful if it > didn't just support duplication. It should allow sampling and then make > the other rule chain (the one that gets hit after sampling) run. > > By allowing a more general form of sampling it could be used for doing > network emulation (or packet manipulation) as well as simple netflow/ipfix > style sampling. > What is network emulation? I think that what you are suggesting is a different feature. There is high penalty for rules duplication, like I stated in my previous reply. As I can see there is no plan at least in Mellanox to support this kind of feature you are suggesting, Since this API in any case is experimental. I suggest that when the need comes or some other vendor will wish to implement such a feature we can ether update the API or create a new one. What do you think?
Best, Ori
