On Mon, 6 Jul 2020 20:51:01 +0300 Jiawei Wang <jiaw...@mellanox.com> wrote:
> This patch set implement the flow sampling for mlx5 driver. > > The solution is introduced a new rte_flow action that will sample the > incoming traffic and send a duplicated traffic with the specified ratio to > the application, while the original packet will continue to the target > destination. > > If the sample ratio value be set to 1, means that the packets would be > completely mirrored. The sample packet can be assigned with different set of > actions from the original packet. > > MLX5 PMD driver will be responsible for validate and translate the sample > action while creating a flow. > You seem to have ignored my feedback that this could be more useful if it didn't just support duplication. It should allow sampling and then make the other rule chain (the one that gets hit after sampling) run. By allowing a more general form of sampling it could be used for doing network emulation (or packet manipulation) as well as simple netflow/ipfix style sampling.
