> > ---------------------------------------------------------------------- > > > > > +#include "otx2_ipsec_po.h" > > > > Why is it named like this? What is 'po' ? > > > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > > inline and one for lookaside. The one for inline is FP and the one for > > > lookaside is PO (Protocol Offload). > > > > > Isn't it better to write "inline" in place of "fp" and "offload" in place > > of "po"? > > > > Fp and po looks very cryptic. > > [Anoob] Yes. But since it is firmware specific, these need to be added for all > structures etc. And these opcodes can be used interchangeably as well (as in > PO > opcode can be used for inline and FP opcodes can be used for lookaside, but > both with certain limitations). Hence we have tried to separate it out this > way. > Larger names would mean longer function names and structure names etc. We > tried few other names as well, but then it was conflicting with other > opcodes. I > do agree that it is slightly cryptic, but we have tried to use the names > consistently to avoid confusions. > I think you can use the opcode as fp and po but the function/file names should be readable. However, it is internal to PMD, I don't have a strong opinion on this but it would be good if Names can be made readable.
Regards, Akhil
