On Thu, May 14, 2020 at 01:39:45PM -0700, Pallavi Kadam wrote:
> This patch fixes bunch of warnings when compiling on Windows
> such as the use of an unsafe string function (strerror),
> [-Wunused-const-variable] in getopt.c and
> [-Wunused-variable], [-Wunused-function] in eal_common_options.c
>
> v2 changes:
> Excluded dirent.h file on Windows temporarily.
> (This file will stay on Windows for later use)
>
> Signed-off-by: Ranjit Menon <ranjit.me...@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.ka...@intel.com>
> Tested-by: Pallavi Kadam <pallavi.ka...@intel.com>
> ---
>
Glad to see those warnings gone!
Tested with clang, FYI it looks like there's only one warning left. We use
"attr" in the pthread_create call, but in the pthread_create macro definition
we ignore the attribute parameter.
[13/30] Compiling C object
lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_thread.c.obj.
../lib/librte_eal/common/eal_common_thread.c:180:25: warning: unused parameter
'attr' [-Wunused-parameter]
const pthread_attr_t *attr,
^
1 warning generated.
Otherwise,
Acked-by: Narcisa Vasile <navas...@linux.microsoft.com>
