28/05/2020 16:37, Power, Ciara: > From: Thomas Monjalon <tho...@monjalon.net> > >06/05/2020 11:55, Ciara Power: > >> This patch modifies the arguments expected by the check-git-log > >> script, to match the format of arguments for the checkpatches script. > >> Both scripts now take certain argument options in the same format, > >> making them easier to use. > >> e.g. Both now take a commit ID range by "-r <range>" > >[...] > >> - usage: $(basename $0) [-h] [range] > >> + usage: $(basename $0) [-h] [-nX|-r range] > > > >Why not specifying that range can be also the first argument? > >It is a discrepancy with what is documented in > >doc/guides/contributing/patches.rst > > > > I didn't include the old format (that takes range as first argument) here to > encourage > using the standardised format moving forward, but anyone that uses the old > format > via scripts etc. will not see any difference in use.
OK So maybe just add a comment in the script on the old argument parsing to mention it is the old syntax. > I can also update the doc to show this standardised format to avoid > discrepancy. Yes please replace with the new syntax in the doc.
