28/05/2020 12:09, Dmitry Kozlyuk: > On Thu, 28 May 2020 09:59:13 +0200 > Thomas Monjalon <tho...@monjalon.net> wrote: > > > 25/05/2020 02:37, Dmitry Kozlyuk: > > > * eal_file_lock: lock or unlock an open file. > > > * eal_file_truncate: enforce a given size for an open file. > > [...] > > > Implementation for Linux and FreeBSD is placed in "unix" subdirectory, > > > which is intended for common code between the two. Files should be named > > > after the ones from which the code is factored in OS subdirectory. > > [...] > > > lib/librte_eal/unix/eal_unix.c | 51 ++++++++++++++++++++++ > > > > Why naming this file eal_unix? > > If it's truly global, it should be unix/eal.c > > We've already discussed this: Makefiles are written in such way that files in > common and arch directories must have distinct names for OS-specific ones. > Until Makefiles exist, this is consistent naming with the rest of librte_eal.
Oh right. > > If it's only about file operations, it could be unix/eal_file.c > > Good suggestion, given that more file-related functions are expected to be > extracted here in future (e.g. for tracing). > > > Please update MAINTAINERS when creating a new file. > > All files or directories must be listed in MAINTAINERS, > > even if there is no maintainer for them. > > Will do. Thanks
