On Mon, May 25, 2020 at 6:08 AM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> wrote: > > It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows, > sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs. > Tracepoints using "long" field emitter are therefore invalid there. > Add dedicated field emitter for size_t and use it to store size_t values > in all existing tracepoints. > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > ---
The Doxygen comment for the new emit function is missing. See https://github.com/DPDK/dpdk/blob/master/lib/librte_eal/include/rte_trace_point.h#L138 Other than the above nit, rest looks good to me.
