On Thu, May 14, 2020 at 6:08 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: > > On 5/14/2020 4:32 PM, David Marchand wrote: > > On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >> > >> On v20.02 some meter APIs have been matured and symbols moved from > >> EXPERIMENTAL to DPDK_20.0.1 block. > >> > >> This can break the applications that were using these mentioned APIs on > >> v19.11. Although there is no modification on the APIs and the action is > >> positive and matures the APIs, the affect can be negative to > >> applications. > >> > >> Since experimental APIs can change or go away without notice as part of > >> contract, to prevent this negative affect that may occur by maturing > >> experimental API, a process update already suggested, which enables > >> aliasing without forcing it: > >> https://patches.dpdk.org/patch/65863/ > >> > >> This patch provides aliasing by duplicating the existing and versioned > >> symbols as experimental. > >> > >> Since symbols moved from DPDK_20.0.1 to DPDK_21 block in the v20.05, the > >> aliasing done between EXPERIMENTAL and DPDK_21. > >> > >> Also following changes done to enabling aliasing: > >> > >> Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > > > This helper (+ script update) must come with the process update: the > > macro is referenced in its v5 revision. > > The macro is implementation detail, and this patch does the implementation. > There is a dependency to process update patch, but that doesn't need to define > how the macro should be.
This is inconsistent. The process update patch gives a clear example of how the macro must be used. -- David Marchand
