Tested-by: Jiang, YuX <yux.ji...@intel.com>
-----Original Message-----
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong
Sent: Wednesday, May 13, 2020 8:59 AM
To: Sun, GuinanX <guinanx....@intel.com>
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics
error in flow control mode
On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously with flow control
>mode setting in the state of port start , so NIC statistics error
>occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc()
>when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx....@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct
>ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
>+ ixgbe_setup_fc(hw);
>+
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.
