Hi Akhil, > -----Original Message----- > From: Akhil Goyal <akhil.go...@nxp.com> > Sent: Saturday, May 9, 2020 8:05 PM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib > v0.54 > > Hi Pablo, > > > +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3) > > + processed_ops = process_zuc_hash_op_mb(qp, ops, sessions, > > + num_ops); > > +#else > > processed_ops = process_zuc_hash_op(qp, ops, sessions, > > num_ops); > > +#endif > > break; > > Instead of having a separate name for process_zuc_hash_op in case of newer > IMB version, Is it not better to have same name of the function but having > different definitions for different IMB version. This way you can reduce the > #ifs > in the code.
Good suggestion. Will send a v2 shortly. Thanks, Pablo > > Regards, > Akhil
