08/05/2020 00:50, Dmitry Kozlyuk: > On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote: > > +static > > +int get_device_pci_address(HDEVINFO hDevInfo, > > + PSP_DEVINFO_DATA pDeviceInfoData, struct rte_pci_addr *addr) > > Result type should be on a separate line (that is, "static int <line break>"). > > This is also the first from numerous violations of DPDK naming conventions. > IMO, Windows EAL should strictly follow them to become "a first-class citizen" > in DPDK and to attract existing developers. Even if not, style should be at > least consistent across each file (now we have snake_case, Hungarian > notation, camelCase, and PascalCase mixed).
I agree, snake_case must be used for all variables.
