On 5/3/2020 8:17 AM, Dekel Peled wrote: > Specified pattern may be translated in different manner. > For example the pattern "eth / ipv4" can be translated to match > untagged packets only, since the pattern doesn't specify a VLAN item. > It can also be translated to match both tagged and untagged packets, > for the same reason. > This patch updates the rte_flow documentation to clearly specify the > required pattern to use. > For example: > To match tagged ipv4 packets, the pattern "eth / vlan / ipv4 / end" > should be used. > To match untagged ipv4 packets, the pattern "eth / ipv4 / end" > should be used. > To match all IPV4 packets, both tagged and untagged, need to apply > two rules with the patterns above. > To match both tagged and untagged packets of any type, the pattern > "eth / end" should be used. > > Signed-off-by: Dekel Peled <dek...@mellanox.com>
Good to have this clarification, but also I believe we should notify the PMD maintainers in case there are different implementations. I have cc'ed the PMD maintainers that implemented flow_ops, to notify from the change, planning to wait one or two more days before merging it.
