>-----Original Message----- >From: Andrew Rybchenko <arybche...@solarflare.com> >Sent: Monday, May 4, 2020 1:17 PM >To: Wisam Monther <wis...@mellanox.com>; dev@dpdk.org; Jack Min ><jack...@mellanox.com>; Thomas Monjalon <tho...@monjalon.net>; >jerinjac...@gmail.com; gerlitz...@gmail.com; l....@epfl.ch >Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow >performance skeleton > >On 4/30/20 1:33 PM, Wisam Jaddo wrote: >> Add flow performance application skeleton. >> >> Signed-off-by: Wisam Jaddo <wis...@mellanox.com> >> --- >> MAINTAINERS | 5 + >> app/Makefile | 1 + >> app/meson.build | 1 + >> app/test-flow-perf/Makefile | 26 +++ >> app/test-flow-perf/main.c | 246 +++++++++++++++++++++++++++ >> app/test-flow-perf/meson.build | 11 ++ >> app/test-flow-perf/user_parameters.h | 16 ++ >> config/common_base | 5 + >> doc/guides/tools/flow-perf.rst | 69 ++++++++ >> doc/guides/tools/index.rst | 1 + >> 10 files changed, 381 insertions(+) >> create mode 100644 app/test-flow-perf/Makefile create mode 100644 >> app/test-flow-perf/main.c create mode 100644 >> app/test-flow-perf/meson.build create mode 100644 >> app/test-flow-perf/user_parameters.h >> create mode 100644 doc/guides/tools/flow-perf.rst >> >> diff --git a/MAINTAINERS b/MAINTAINERS index d31a809292..b5632c1bf5 >> 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1504,6 +1504,11 @@ T: git://dpdk.org/next/dpdk-next-net >> F: app/test-pmd/ >> F: doc/guides/testpmd_app_ug/ >> >> +Flow performance tool >> +M: Wisam Jaddo <wis...@mellanox.com> >> +F: app/test-flow-perf >> +F: doc/guides/flow-perf.rst >> + > >Shouldn't it be alphabetially sorted? I think by app name.
It looks no, Current order: - Sample_packet_forward - test-pmd - comp_perf - eventdev - proc-info So I'll move the new app to be in the end of the test apps, since it's been added last, is this ok?
