> Subject: Re: [PATCH v2 7/7] bus/pci: support Windows with bifurcated
> drivers
>
> On 2020-04-28 12:11 GMT+0300 tal...@mellanox.com wrote:
> [snip]
> > + switch (dev->kdrv) {
> > + case RTE_KDRV_NONE:
> > + /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> > + bResult = SetupDiGetDevicePropertyW(hDevInfo,
> pDeviceInfoData,
> > + &DEVPKEY_Device_Numa_Node, &uPropertyType,
> > + (BYTE *)&uNumaNode, sizeof(uNumaNode), NULL,
> 0);
> > + if (!bResult) {
> > + ret = GetLastError();
> > + goto end;
> > + }
> > + dev->device.numa_node = uNumaNode;
>
> Note: NUMA node != socket ID, but this field is used as socket ID by PMDs.
> I suggest adding Windows-only EAL API to do the translation.
Thank you for the review and notes Dmitry, will apply in v3.
Regarding numa node and socket id, AFAIK in x86 processors numa node == socket
id
In other processors that is not the case but of the current Windows support of
DPDK the
Implementation above should be sufficient.
> [snip]
