On Tue, Apr 7, 2020 at 11:29 AM Sunil Kumar Kori <sk...@marvell.com> wrote: > > rte_bus_scan API scans all the available PCI devices irrespective of white > or black listing parameters then further devices are probed based on white > or black listing parameters. So unnecessary CPU cycles are wasted during > rte_pci_scan. > > For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_scan consumes > around 26ms to scan around 90 PCI devices but all may not be used by the > application. So for the application which uses 2 NICs, rte_bus_scan > consumes few microseconds and rest time is saved with this patch. > > Patch restricts devices to be scanned as per below mentioned conditions: > - All devices will be scanned if no parameters are passed. > - Only white listed devices will be scanned if white list is available. > - All devices, except black listed, will be scanned if black list is > available. > > Signed-off-by: Sunil Kumar Kori <sk...@marvell.com> > --- > v2: > - Added function to validate ignorance of device based on PCI address.
First you objected to Stephen comment, and later announced there was no objection. Now, it seems you ignored what I replied without any explanation. So tell me, what was wrong with https://github.com/david-marchand/dpdk/commit/e7860231ecdce91f9f70027d4090a7057b8fd5f7 ? > - Marked device validation function as experimental. Useless, this symbol is internal and not exported. -- David Marchand