On Tue, Apr 7, 2020 at 1:33 PM Neil Horman <nhor...@tuxdriver.com> wrote: > > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman <nhor...@tuxdriver.com> wrote: > > > > > > Since we've moved away from our initial abi_versioning.sh script, in > > > > abi_versioning.sh does not exist (idem with the patch title). > > I suppose you meant validate-abi.sh. > > > Crud, you're right, I was convoluting terms, sorry. Shall I repost with a > corrected changelog?
Yes, and with the other comment I did earlier, addressed too. > > > favor of check_abi.sh, which uses libabigail, remove the old script from > > > > check-abi.sh > > > > > the tree, and update the docs accordingly > > > > > > > [snip] > > > > > diff --git a/doc/guides/contributing/abi_versioning.rst > > > b/doc/guides/contributing/abi_versioning.rst > > > index a21f4e7a4..1c4a3f927 100644 > > > --- a/doc/guides/contributing/abi_versioning.rst > > > +++ b/doc/guides/contributing/abi_versioning.rst > > > @@ -482,9 +482,9 @@ Running the ABI Validator > > > ------------------------- > > > > > > The ``devtools`` directory in the DPDK source tree contains a utility > > > program, > > > -``validate-abi.sh``, for validating the DPDK ABI based on the Linux `ABI > > > -Compliance Checker > > > -<http://ispras.linuxbase.org/index.php/ABI_compliance_checker>`_. > > > +``check-abi.sh``, for validating the DPDK ABI based on the libabigail > > > abidiff > > > +utility: > > > +https://sourceware.org/libabigail/manual/abidiff.html > > > > > > This has a dependency on the ``abi-compliance-checker`` and ``and > > > abi-dumper`` > > > utilities which can be installed via a package manager. For example:: > > > @@ -492,9 +492,9 @@ utilities which can be installed via a package > > > manager. For example:: > > > sudo yum install abi-compliance-checker > > > sudo yum install abi-dumper > > > > > > -The syntax of the ``validate-abi.sh`` utility is:: > > > +The syntax of the ``check-abi.sh`` utility is:: > > > > > > - ./devtools/validate-abi.sh <REV1> <REV2> > > > + ./devtools/check-abi.sh <REV1> <REV2> > > > > The new script is not a direct replacement. > > It won't take git revisions, but build directories where versions of > > dpdk have been compiled. > > > > devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its use. > > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 > > Thanks. -- David Marchand
