Hi all, >> Alternatively, we could expand the meaning of ETH_SPEED_NUM_NONE: >> -#define ETH_SPEED_NUM_NONE 0 /**< Not defined */ >> +#define ETH_SPEED_NUM_NONE 0 /**< Not defined or unknown >> (virtual device) */ > Yes I agree with extending the comment for NONE. >> The special value could also be used in cases like this: >> >> http://inbox.dpdk.org/dev/am0pr0502mb401907ade7cea27dc642df35d2...@am0pr0502mb4019.eurprd05.prod.outlook.com/T/#t > Yes, if speed is unknown, it should be reported as 0.
Ok that should answer Matan concerns: it is perfectly fine for a PMD to return ETH_SPEED_NUM_NONE if it does not have better information. >From my app writer point of view it makes sense. Best ben
