> -----Original Message-----
> From: Di, ChenxuX <chenxux...@intel.com>
> Sent: Wednesday, March 18, 2020 09:47
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; Di, ChenxuX
> <chenxux...@intel.com>
> Subject: [PATCH 1/4] net/e1000: remove the legacy filter functions
>
> remove the legacy filter functions in Intel igb driver.
>
> Signed-off-by: Chenxu Di <chenxux...@intel.com>
> ---
> doc/guides/rel_notes/release_20_05.rst | 9 +++++++
> drivers/net/e1000/igb_ethdev.c | 36 --------------------------
> 2 files changed, 9 insertions(+), 36 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 2190eaf85..e79f8d841 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -56,6 +56,15 @@ New Features
> Also, make sure to start the actual text at the margin.
>
> =========================================================
>
> +* **remove legacy filter API and switch to rte flow**
> +
> + remove legacy filter API functions and switch to rte_flow in drivers,
> including:
> +
> + * remove legacy filter API functions in the Intel igb driver.
> + * remove legacy filter API functions in the Intel ixgbe driver.
> + * remove legacy filter API functions in the Intel i40 driver.
You only delete parts of the legacy function.
> + * Added support set hash function and set hash input set in rte flow API.
> +
>
> Removed Items
> -------------
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index 520fba8fa..2d660eb7e 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -3716,16 +3716,6 @@ eth_igb_syn_filter_handle(struct rte_eth_dev
> *dev,
> }
>
> switch (filter_op) {
> - case RTE_ETH_FILTER_ADD:
> - ret = eth_igb_syn_filter_set(dev,
> - (struct rte_eth_syn_filter *)arg,
> - TRUE);
> - break;
> - case RTE_ETH_FILTER_DELETE:
> - ret = eth_igb_syn_filter_set(dev,
> - (struct rte_eth_syn_filter *)arg,
> - FALSE);
> - break;
> case RTE_ETH_FILTER_GET:
> ret = eth_igb_syn_filter_get(dev,
> (struct rte_eth_syn_filter *)arg);
> @@ -4207,12 +4197,6 @@ eth_igb_flex_filter_handle(struct rte_eth_dev
> *dev,
> }
>
> switch (filter_op) {
> - case RTE_ETH_FILTER_ADD:
> - ret = eth_igb_add_del_flex_filter(dev, filter, TRUE);
> - break;
> - case RTE_ETH_FILTER_DELETE:
> - ret = eth_igb_add_del_flex_filter(dev, filter, FALSE);
> - break;
> case RTE_ETH_FILTER_GET:
> ret = eth_igb_get_flex_filter(dev, filter);
> break;
> @@ -4713,16 +4697,6 @@ igb_ntuple_filter_handle(struct rte_eth_dev *dev,
> }
>
> switch (filter_op) {
> - case RTE_ETH_FILTER_ADD:
> - ret = igb_add_del_ntuple_filter(dev,
> - (struct rte_eth_ntuple_filter *)arg,
> - TRUE);
> - break;
> - case RTE_ETH_FILTER_DELETE:
> - ret = igb_add_del_ntuple_filter(dev,
> - (struct rte_eth_ntuple_filter *)arg,
> - FALSE);
> - break;
> case RTE_ETH_FILTER_GET:
> ret = igb_get_ntuple_filter(dev,
> (struct rte_eth_ntuple_filter *)arg); @@ -4894,16
> +4868,6 @@ igb_ethertype_filter_handle(struct rte_eth_dev *dev,
> }
>
> switch (filter_op) {
> - case RTE_ETH_FILTER_ADD:
> - ret = igb_add_del_ethertype_filter(dev,
> - (struct rte_eth_ethertype_filter *)arg,
> - TRUE);
> - break;
> - case RTE_ETH_FILTER_DELETE:
> - ret = igb_add_del_ethertype_filter(dev,
> - (struct rte_eth_ethertype_filter *)arg,
> - FALSE);
> - break;
> case RTE_ETH_FILTER_GET:
> ret = igb_get_ethertype_filter(dev,
> (struct rte_eth_ethertype_filter *)arg);
> --
> 2.17.1
