David Marchand <david.march...@redhat.com> writes:
> On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren
> <harry.van.haa...@intel.com> wrote:
>>
>> This commit releases all service cores from their role,
>> returning them to ROLE_RTE on rte_service_finalize().
>>
>> This may fix an issue relating to the service cores causing
>
> You don't seem convinced.
>
>
>> a race-condition on eal_cleanup(), where the service core
>> could still be executing while the main thread has already
>> free-d the service memory, leading to a segfault.
>>
>> Fixes: 21698354c832 ("service: introduce service cores concept")
>> Cc: sta...@dpdk.org
>>
>> Reported-by: David Marchand <david.march...@redhat.com>
>> Reported-by: Aaron Conole <acon...@redhat.com>
>> Signed-off-by: David Marchand <david.march...@redhat.com>
>> Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
>> Acked-by: Aaron Conole <acon...@redhat.com>
>
> I am okay with merging this so that we stop getting random failures of the ut.
I think it could also potentially cause errors in user applications that
regularly exit, and which use the service core architecture. So it's
worth getting in now, anyway.
> I will let this patch on the ml and apply on Friday at worse.
>
> Please take the time to reply to my question.
> Thanks.
