On Tue, 21 Jan 2020 15:01:57 +0100
Olivier Matz <[email protected]> wrote:
> > I've checked the rte_mempool_get_priv() usage - in all header files there
> > are the type casts. The "rte_mbuf.h" contains the rte_pktmbuf_priv_size()
> > and
> > rte_pktmbuf_data_room_size(), both provide the cast. What is the reason?
> > C++ compatibility? Should we remove the cast in rte_pktmbuf_priv_flags()?
>
> Removing the cast will certainly break C++ code using this header.
> There is a similar case in commit a2ff2827dc84 ("mbuf: fix C++ build on
> void pointer cast")
>
> In my opinion it can stay as it is now.
Agreed. Thanks for trying.
