>-----Original Message----- >> > Not sure how users could make use of this. >> > But the abi check flags this as a breakage since this type was exported. >> I think this is a false positive. >> >> Users include 'rte_hash.h' file which does not define the structure. It just >> has the declaration 'struct rte_hash'. The actual structure is >defined in 'rte_cuckoo_hash.h'. But this is not included by the user. So, the >application does not have visibility into 'struct rte_hash' as >defined in 'rte_cuckoo_hash.h'. >> >> The 'rte_create_hash' API returns a pointer to the 'struct rte_hash'. All >> the APIs are non-inline and just take this pointer as the >argument. So, the 'struct rte_hash' as defined in 'rte_cuckoo_hash.h' is not >used by the user. > >Indeed, it seems properly hidden. >Scratching the rest of the mail. > >Looked at abidiff, I can see it takes a public headers directory to >filter the ABI changes. >Need to make this work. > > >-- >David Marchand
[Wang, Yipeng] Hi, Honnappa, I read the new API defs and this patch to rte_hash looks good to me. Passed unit tests as well. And I agree with you that the internals of rte_hash is hidden from users. As long as the false warning in abi-check script is no concern: Acked-by: Yipeng Wang <yipeng1.w...@intel.com>
