On 2020-01-17 14:34, Jerin Jacob wrote: > On Fri, Jan 17, 2020 at 5:44 PM David Marchand > <david.march...@redhat.com> wrote: >> On Thu, Jan 16, 2020 at 5:36 PM Honnappa Nagarahalli >> <honnappa.nagaraha...@arm.com> wrote: >>> I see that the none of the CIs (except Travis) have run on this patch. >>> Intel CI has reported a compilation error and I fixed it in this version. >>> Does anyone know if/when the CI will run on the patches? >> - Pushed the series >> https://patchwork.dpdk.org/project/dpdk/list/?series=8147 to a branch >> of mine for checks. >> Travis reports: >> " >> [2155/2156] Compiling C object >> 'app/te...st@@dpdk-test@exe/test_ring_perf.c.o'. >> >> No output has been received in the last 10m0s, this potentially >> indicates a stalled build or something wrong with the build itself. >> >> Check the details on how to adjust your build configuration on: >> https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received >> >> The build has been terminated >> " >> >> I see you discussed this already with Aaron, did I miss something? >> >> >> - Besides, I have no ack/review from the hash and eventdev maintainers. > + Bruce, Harry, Mattias > > Even though event ring added in the eventdev common code, it's been > used only by SW eventdev drivers. > So adding evendev ring author and SW driver maintainers for review.
I endorse this change, although I hadn't have time to review the code. DSW throughput increases ~5% on x86_64 after applying this patchset, so the goal of maintaining legacy performance seems to have been met (and exceeded). I will look into using these new custom-sized rings for the DSW control rings (which uses regular DPDK void-pointer rings today).
