Hi Qi,
> -----Original Message----- > From: Zhang, Qi Z <qi.z.zh...@intel.com> > Sent: Thursday, January 9, 2020 12:44 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org; > Xing, Beilei <beilei.x...@intel.com>; Doherty, Declan > <declan.dohe...@intel.com> > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Byrne, Stephen1 > <stephen1.by...@intel.com>; Zhang, Helin <helin.zh...@intel.com> > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director packet > > Hi Bernard: > > > -----Original Message----- > > From: Iremonger, Bernard <bernard.iremon...@intel.com> > > Sent: Thursday, January 9, 2020 8:17 PM > > To: dev@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z > > <qi.z.zh...@intel.com>; Doherty, Declan <declan.dohe...@intel.com> > > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Byrne, > > Stephen1 <stephen1.by...@intel.com>; Zhang, Helin > > <helin.zh...@intel.com>; Iremonger, Bernard > > <bernard.iremon...@intel.com> > > Subject: [PATCH v3 6/9] net/i40e: display Flow Director packet > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > > --- > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > b/drivers/net/i40e/i40e_fdir.c index > > 3fa6297..78329d2 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -21,6 +21,7 @@ > > #include <rte_tcp.h> > > #include <rte_sctp.h> > > #include <rte_hash_crc.h> > > +#include <rte_hexdump.h> > > > > #include "i40e_logs.h" > > #include "base/i40e_type.h" > > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > > rte_eth_fdir_input *fdir_input, > > fdir_input->flow_type); > > return -1; > > } > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > Why we need this? Does this just for debug? Useful to see the packet constructed by this function, otherwise no visibility on what is happening. Needed for debug. > > Regards > Qi > > > return len; > > } > > > > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > > &fdir_input->flow_ext.flexbytes[dst], > > size * sizeof(uint16_t)); > > } > > - > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > return 0; > > } > > > > -- > > 2.7.4 > Regards, Bernard.
