On Tue, Jan 7, 2020 at 11:11 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > The rte_eal_cleanup code is not exercised by testpmd which > is the most used DPDK test tool. Add a call at end of program. > > This helps exercise free and close paths which can > be checked with tools like valgrind. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index b3746822366f..a94ad19c8f5a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3570,5 +3570,6 @@ main(int argc, char** argv) > return 1; > } > > + rte_eal_cleanup(); > return 0;
# How about changing to "return rte_eal_cleanup()" to provide OS the correct stats? # IMO, we need the same in other applications main() and signal handler too. > } > -- > 2.20.1 >
