On 12/19/2019 10:18 PM, Alfredo Cardigliano wrote:
> Register the Pensando ionic PMD (net_ionic) and define initial probe
> and remove callbacks with adapter initialization.
>
> Signed-off-by: Alfredo Cardigliano <cardigli...@ntop.org>
> Reviewed-by: Shannon Nelson <snel...@pensando.io>
<...>
> +static int
> +eth_ionic_pci_remove(struct rte_pci_device *pci_dev)
> +{
> + return 0;
> +}
This function causing build error on patch by patch build, because of unused
'pci_dev' variable, it needs to be used as unused:
error: unused parameter 'pci_dev' [-Werror,-Wunused-parameter]
<...>
> +int32_t
> +ionic_set_mac_type(struct ionic_hw *hw)
> +{
> + int err = 0;
> +
> + IONIC_PRINT_CALL();
> +
> + if (hw->vendor_id != IONIC_PENSANDO_VENDOR_ID) {
> + IONIC_PRINT(ERR, "Unsupported vendor id: %" PRIx32 "",
> + hw->vendor_id);
Causing following build error on patch by patch build, need to add "#include
<inttypes.h>", since ionic_dev.c also fails in this patch, adding include to
ionic.h can fix both.
.../drivers/net/ionic/ionic_mac_api.c:38:47: error: expected ')'
IONIC_PRINT(ERR, "Unsupported vendor id: %" PRIx32 "",
^
.../drivers/net/ionic/ionic_mac_api.c:38:3: note: to match this '('
IONIC_PRINT(ERR, "Unsupported vendor id: %" PRIx32 "",
^
.../drivers/net/ionic/ionic_logs.h:12:49: note: expanded from macro
'IONIC_PRINT'
#define IONIC_PRINT(level, fmt, args...) rte_log(RTE_LOG_ ## level, \
^
