> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, December 16, 2019 10:44 AM
> To: Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>
> Cc: dev@dpdk.org; Stillwell Jr, Paul M <paul.m.stillwell...@intel.com>; Ye,
> Xiaolong <xiaolong...@intel.com>; Loktionov, Aleksandr
> <aleksandr.loktio...@intel.com>
> Subject: [PATCH v3 36/36] net/i40e/base: add new link speed constants
>
> This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb/5Gb
> speeds. This problem is fixed by adding constants for
> VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB.
>
It's a fix patch, fix line is needed? The same comment is also for patch 27/36,
25/36, 21/36, 14/36.
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
> Signed-off-by: Xiaolong Ye <xiaolong...@intel.com>
> ---
> drivers/net/i40e/base/i40e_prototype.h | 4 ++++
> drivers/net/i40e/base/virtchnl.h | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/net/i40e/base/i40e_prototype.h
> b/drivers/net/i40e/base/i40e_prototype.h
> index 0f06e3262..d8ab3ea0a 100644
> --- a/drivers/net/i40e/base/i40e_prototype.h
> +++ b/drivers/net/i40e/base/i40e_prototype.h
> @@ -505,6 +505,10 @@ i40e_virtchnl_link_speed(enum i40e_aq_link_speed
> link_speed)
> return VIRTCHNL_LINK_SPEED_100MB;
> case I40E_LINK_SPEED_1GB:
> return VIRTCHNL_LINK_SPEED_1GB;
> + case I40E_LINK_SPEED_2_5GB:
> + return VIRTCHNL_LINK_SPEED_2_5GB;
> + case I40E_LINK_SPEED_5GB:
> + return VIRTCHNL_LINK_SPEED_5GB;
> case I40E_LINK_SPEED_10GB:
> return VIRTCHNL_LINK_SPEED_10GB;
> case I40E_LINK_SPEED_40GB:
> diff --git a/drivers/net/i40e/base/virtchnl.h
> b/drivers/net/i40e/base/virtchnl.h
> index c613d4761..92515bf34 100644
> --- a/drivers/net/i40e/base/virtchnl.h
> +++ b/drivers/net/i40e/base/virtchnl.h
> @@ -53,12 +53,14 @@ enum virtchnl_status_code { #define
> VIRTCHNL_ERR_PARAM VIRTCHNL_STATUS_ERR_PARAM #define
> VIRTCHNL_STATUS_NOT_SUPPORTED
> VIRTCHNL_STATUS_ERR_NOT_SUPPORTED
>
> +#define VIRTCHNL_LINK_SPEED_2_5GB_SHIFT 0x0
> #define VIRTCHNL_LINK_SPEED_100MB_SHIFT 0x1
> #define VIRTCHNL_LINK_SPEED_1000MB_SHIFT 0x2
> #define VIRTCHNL_LINK_SPEED_10GB_SHIFT 0x3
> #define VIRTCHNL_LINK_SPEED_40GB_SHIFT 0x4
> #define VIRTCHNL_LINK_SPEED_20GB_SHIFT 0x5
> #define VIRTCHNL_LINK_SPEED_25GB_SHIFT 0x6
> +#define VIRTCHNL_LINK_SPEED_5GB_SHIFT 0x7
>
> enum virtchnl_link_speed {
> VIRTCHNL_LINK_SPEED_UNKNOWN = 0,
> @@ -68,6 +70,8 @@ enum virtchnl_link_speed {
> VIRTCHNL_LINK_SPEED_40GB =
> BIT(VIRTCHNL_LINK_SPEED_40GB_SHIFT),
> VIRTCHNL_LINK_SPEED_20GB =
> BIT(VIRTCHNL_LINK_SPEED_20GB_SHIFT),
> VIRTCHNL_LINK_SPEED_25GB =
> BIT(VIRTCHNL_LINK_SPEED_25GB_SHIFT),
> + VIRTCHNL_LINK_SPEED_2_5GB =
> BIT(VIRTCHNL_LINK_SPEED_2_5GB_SHIFT),
> + VIRTCHNL_LINK_SPEED_5GB =
> BIT(VIRTCHNL_LINK_SPEED_5GB_SHIFT),
> };
>
> /* for hsplit_0 field of Rx HMC context */
> --
> 2.17.1
