Re: [dpdk-dev] [PATCH] net/bnxt: add support for flow mark action

[Lance Richardson]

On Fri, Dec 13, 2019 at 5:42 PM Ajit Khaparde
<ajit.khapa...@broadcom.com> wrote:
>
> Add support for RTE_FLOW_ACTION_TYPE_MARK
> Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> ---

<snip>

> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c 
> b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index 22d9f9e84..ce00da633 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -280,8 +280,14 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf 
> **rx_pkts,
>
>                         rte_compiler_barrier();
>
> -                       if (rxcmp->flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID)
> +                       if (rxcmp->flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) {
>                                 mbuf->ol_flags |= PKT_RX_RSS_HASH;
> +                       } else {
> +                               mbuf->hash.fdir.id =
> +                                       bnxt_get_cfa_code_or_mark_id(rxq->bp,
> +                                                                    rxcmp1);
> +                               mbuf->ol_flags |= PKT_RX_FDIR | 
> PKT_RX_FDIR_ID;
> +                       }
>
>                         if (rxcmp1->flags2 &
>                             RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN) {
> --
> 2.21.0 (Apple Git-122.2)
>

Hi Ajit,

IMO this functionality should not be supported in vector mode.

Regards,

    Lance