On 12/12/2019 12:01 PM, Alfredo Cardigliano wrote: > > >> On 10 Dec 2019, at 19:48, Ferruh Yigit <ferruh.yi...@intel.com> wrote: >> >> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >>> Add makefile and config file options to compile the Pensando ionic PMD. >>> Add feature and version map file. >>> Update maintainers file. >>> >>> Signed-off-by: Alfredo Cardigliano <cardigli...@ntop.org> >>> Reviewed-by: Shannon Nelson <snel...@pensando.io> >> >> <...> >> >>> @@ -277,6 +277,11 @@ CONFIG_RTE_LIBRTE_E1000_DEBUG_TX=n >>> CONFIG_RTE_LIBRTE_E1000_DEBUG_TX_FREE=n >>> CONFIG_RTE_LIBRTE_E1000_PF_DISABLE_STRIP_CRC=n >>> >>> +# >>> +# Compile Pensando IONIC PMD driver >>> +# >>> +CONFIG_RTE_LIBRTE_IONIC_PMD=y >>> + >> >> Is the driver supported by BSD platform or i686, arm, PPC architectures? If >> not >> can you please disable the PMD on those config files? > > I guess setting ’n’ in defconfig_* will override common_base settings.
Yes, that should be enough. It is hierarchical and child overwrites parent's values. > Is there any documentation that I can check for this? Thank you. > >> <...> >> >>> diff --git a/doc/guides/nics/ionic.rst b/doc/guides/nics/ionic.rst >>> new file mode 100644 >>> index 000000000..41eac0f6b >>> --- /dev/null >>> +++ b/doc/guides/nics/ionic.rst >>> @@ -0,0 +1,37 @@ >>> +.. SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) >>> + Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. >>> + >>> +IONIC Driver >>> +============ >>> + >>> +The ionic driver provides support for Pensando server adapters. >>> +Please visit https://pensando.io for more information about the >>> +adapters. >> >> Thanks for providing the company link, that was useful. But also can you >> please >> provide a link that has the details of the device that 'ionic' driver is for. >> I can see some documentation related to Naples DSC-xx devices but I assume >> they >> are something else. >> Btw, related to the HW you are providing the driver for, is it publicly >> available now or are the documentation like specs/datasheets provided >> publicly? > > The website is fairly new and more docs will be available soon from > https://pensando.io/platform > Product briefs are available at the moment from the same page, is it fine to > link them? > https://pensando.io/assets/documents/Naples_100_ProductBrief-10-2019.pdf > https://pensando.io/assets/documents/Naples-25_ProductBrief_10-2019.pdf Is the device this driver for "naples"? It wasn't clear to me. If it is, yes please share their link in doc.
