On 12/9/2019 1:38 PM, Pattan, Reshma wrote: > > >>>> -----Original Message----- >>>> From: David Marchand <david.march...@redhat.com> >>>>> v3: add missing test event_eth_tx_adapter_autotest. > > Just wondering, if is it ok to send me the v4 by reverting the test case > addition from run for this patch to get accepted, as fixing the test case can > be handled separately.
Is the root cause of the failures missing '-d' parameter, why not provide that instead of not executing the test cases? David, Aaron, Can it be possible to test providing '-d' paramter in travis and see if it fixes the issue? And what do you think splitting the patch into two, one fixes the build issues and other adding the missing testcases to the test suit? > >>> Is this something that Nikhil should look into this as maintainer and fix in >> separate patch, I am afraid this is not my area of expertise. >> >> I agree that someone knowing of this test should be looking at it. >> >> My suggestion on adding this test was based on the fact that we were building >> this code test. >> But I was expecting that you test this addition. >> >> You shall not break the CI :-) >> Please add this to your checklist for future submissions, or at least check >> the >> robot reports. >> >> >> Thanks. >> >> -- >> David Marchand >
