On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add RX and TX queues setup and handling. > > Signed-off-by: Alfredo Cardigliano <cardigli...@ntop.org> > Reviewed-by: Shannon Nelson <snel...@pensando.io>
<...> > @@ -502,6 +614,8 @@ eth_ionic_dev_uninit(struct rte_eth_dev *eth_dev) > ionic_lif_free(lif); > > eth_dev->dev_ops = NULL; > + eth_dev->rx_pkt_burst = NULL; > + eth_dev->tx_pkt_burst = NULL; Can null 'tx_pkt_prepare' too. <...> > + /* Vlan Strip */ > + if (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_VLAN) { > + pkt_flags |= PKT_RX_VLAN_STRIPPED; It looks like VLAN offload is also supported, you can announce this in .ini file. > + rxm->vlan_tci = cq_desc->vlan_tci; Need to set 'PKT_RX_VLAN' to say 'vlan_tci' has a valid value. > + } > + > + /* Checksum */ > + if (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_CALC) { > + if (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_IP_OK) > + pkt_flags |= PKT_RX_IP_CKSUM_GOOD; > + else if (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_IP_BAD) > + pkt_flags |= PKT_RX_IP_CKSUM_BAD; > + > + if ((cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_TCP_OK) || > + (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_UDP_OK)) > + pkt_flags |= PKT_RX_L4_CKSUM_GOOD; > + else if ((cq_desc->csum_flags & > + IONIC_RXQ_COMP_CSUM_F_TCP_BAD) || > + (cq_desc->csum_flags & > + IONIC_RXQ_COMP_CSUM_F_UDP_BAD)) > + pkt_flags |= PKT_RX_L4_CKSUM_BAD; > + } if 'L3 checksum offload' is also supported, you can document that too (in .ini file)