On 11/21/19 1:30 AM, David Marchand wrote: > On Wed, Nov 20, 2019 at 6:28 PM David Marchand > <david.march...@redhat.com> wrote: >> On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: >>> A build error reported related to the selected >>> 'get_user_pages_remote()' kernel API: >>> >>> .../kernel/linux/kni/kni_dev.h:113:8: >>> error: too few arguments to function ‘get_user_pages_remote’ >>> ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 >>> ^~~~~~~~~~~~~~~~~~~~~ >>> >>> Currently there are three version of the 'get_user_pages_remote()' >>> supported, based on kernel version >>> < 4.9, = 4.9, > 4.9 >>> >>> These version based checks are not working fine with the distro kernels >>> which is the cause of reported build error. The error reported by the >>> kernel version 4.8, but it is using API defined in > 4.9. >>> >>> To be able to take control of this, and possible more, related build >>> error, increasing the minimum supported kernel version for iova=va with >>> KNI to kernel version 4.9. >>> >>> This leaves us with single version of the kernel API and more >>> manageable. >>> >>> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > Reviewed-by: David Marchand <david.march...@redhat.com> > > We need this change to fix compilation issues for -rc3. > Applied, thanks.
The build is still broken on Debian 9 stretch which has Linux 4.9.189, but corresponding function still has no the last argument. It looks like requirements should be bumped to >=4.10.0.
