30/10/2019 10:55, Gavin Hu (Arm Technology China): > Hi Thomas, > > From: Thomas Monjalon <tho...@monjalon.net> > > 23/10/2019 04:54, Joyce Kong: > > > There are a lot functions of bit operations scattered in PMDs, > > > consolidate them into a common API family and applied in different > > > PMDs to reduce code duplication. > > > > Please, could you look at what Adrien did in the Mellanox PMD? > > > > http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5_utils.h#L28 > The code has less duplication, but it requires a less natural declaration of > variables > http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5.h#L607 > Should we take this way?
I don't know which way is best. I suggested to read this code for 2 reasons: 1. we can be inspired 2. it may be replaced by the new common API as you did for other drivers
