On Wed, Oct 23, 2019 at 4:55 AM Joyce Kong <joyce.k...@arm.com> wrote: > > There are a lot functions of bit operations scattered in PMDs, > consolidate them into a common API family and applied in different > PMDs to reduce code duplication. > > v2: > 1. Add doxygen comments for the rte bit operation API(suggested by Stephen > Hemminger). > 2. Add test cases for common rte bit operation API(suggested by Stephen > Hemminger). > 3. Change the header file to rte_io_bitops.h and the operation to > rte_io_set_bit()etc., > as the API uses barriers inside and the barriers are only needed for IO > operations > (suggested by Jerin Jacob). > 4. Use an well defined uint_NN_t type(suggested by Morten Brørup).
Thanks for working on this. This series is a cleanup and worth looking at, yet it came rather late. Discussion and enhancement can still continue, but it will be deferred to 20.02. -- David Marchand
